- Aur-dev - lists.archlinux.org

[aur-dev] [PATCH] pkg_search_results.php: Link to account when logged in
by Lukas Fleischer 05 Apr '14

05 Apr '14

Replace the maintainer package search links with links to the maintainer's account when browsing the search results as a logged-in user. Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- web/template/pkg_search_results.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/web/template/pkg_search_results.php b/web/template/pkg_search_results.php index c9da5f9..e47fcb2 100644 --- a/web/template/pkg_search_results.php +++ b/web/template/pkg_search_results.php @@ -73,7 +73,11 @@ if (!$result): ?> <td class="wrap"><?= htmlspecialchars($row['Description'], ENT_QUOTES); ?></td> <td> <?php if (isset($row["Maintainer"])): ?> + <?php if ($SID): ?> + <a href="<?= get_uri('/account/') . htmlspecialchars($row['Maintainer'], ENT_QUOTES) ?>" title="<?= __('View account information for %s', htmlspecialchars($row['Maintainer'])) ?>"><?= htmlspecialchars($row['Maintainer']) ?></a> + <?php else: ?> <a href="<?= get_uri('/packages/'); ?>?K=<?= htmlspecialchars($row['Maintainer'], ENT_QUOTES) ?>&SeB=m"><?= htmlspecialchars($row['Maintainer']) ?></a> + <?php endif; ?> <?php else: ?> <span><?= __("orphan") ?></span> <?php endif; ?> -- 1.9.1

1 0

[aur-dev] [PATCH 0/7] Split package support: Cleanups, fixes, improvements
by Lukas Fleischer 05 Apr '14

05 Apr '14

To be applied on top of the split package patch set. Lukas Fleischer (7): Use snake case for all package functions Prefix package functions with pkg_/pkgbase_ Split out package base functions pkgfuncs.inc.php: Remove several unused functions pkgbasefuncs.inc.php: Fix leftover bits Add full package list to the removal form Do not show package base page of non-split packages scripts/cleanup | 2 +- web/html/index.php | 2 +- web/html/packages.php | 10 +- web/html/pkgbase.php | 38 +- web/html/pkgdel.php | 9 +- web/html/pkgmerge.php | 10 +- web/html/pkgsubmit.php | 20 +- web/html/voters.php | 2 +- web/lib/pkgbasefuncs.inc.php | 968 ++++++++++++++++++++++++++++++++++ web/lib/pkgfuncs.inc.php | 1058 +------------------------------------- web/template/actions_form.php | 4 +- web/template/pkg_comments.php | 4 +- web/template/pkg_details.php | 12 +- web/template/pkg_search_form.php | 2 +- web/template/pkgbase_details.php | 6 +- 15 files changed, 1058 insertions(+), 1089 deletions(-) create mode 100644 web/lib/pkgbasefuncs.inc.php -- 1.9.1

1 6

[aur-dev] [PATCH 00/13] Split package support
by Lukas Fleischer 05 Apr '14

05 Apr '14

This patch series adds full .AURINFO support and split package support. Implementing this requires massive database layout changes and thus, a lot of patches in this series are quite invasive. Things that need to be done: * Testing, the patches are still experimental. * Fix and extend the RPC interface. Suggestions? * Do a lot of refactoring and code cleanup. Lukas Fleischer (13): Add provisional support for package bases Store comments on a per-package base basis routing.inc.php: Add get_pkgbase_uri() Make the delete function remove package bases Add full support for the new .AURINFO format Add package base detail pages pkg_details.php: Add link to package base details Do not allow for overwriting arbitrary packages Factor out PKGBUILD parsing Only parse PKGBUILD when required UPGRADING: Add migration instructions for 3.0.0 Allow for searching by package base name Move package actions to package bases UPGRADING | 124 +++++++++ schema/aur-schema.sql | 44 +-- schema/gendummydata.py | 18 +- web/html/index.php | 18 +- web/html/packages.php | 75 ----- web/html/pkgbase.php | 135 +++++++++ web/html/pkgdel.php | 10 +- web/html/pkgmerge.php | 10 +- web/html/pkgsubmit.php | 432 +++++++++++------------------ web/lib/aur.inc.php | 34 ++- web/lib/pkgbuild-parser.inc.php | 139 ++++++++++ web/lib/pkgfuncs.inc.php | 540 +++++++++++++++++++++++++----------- web/lib/routing.inc.php | 18 ++ web/lib/stats.inc.php | 21 +- web/template/pkg_comment_form.php | 4 +- web/template/pkg_comments.php | 10 +- web/template/pkg_details.php | 34 ++- web/template/pkg_search_form.php | 4 +- web/template/pkg_search_results.php | 4 +- web/template/pkgbase_details.php | 210 ++++++++++++++ 20 files changed, 1304 insertions(+), 580 deletions(-) create mode 100644 web/html/pkgbase.php create mode 100644 web/lib/pkgbuild-parser.inc.php create mode 100644 web/template/pkgbase_details.php -- 1.9.1

1 13

[aur-dev] [PATCH] Fix database schema
by Lukas Fleischer 03 Apr '14

03 Apr '14

Replace "ON SET NULL" with "ON DELETE SET NULL". Fixes a regression introduced in commit fb7bde3 (Add support for anonymous comments, 2014-02-04). Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- schema/aur-schema.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/schema/aur-schema.sql b/schema/aur-schema.sql index 86f7563..932c1d3 100644 --- a/schema/aur-schema.sql +++ b/schema/aur-schema.sql @@ -167,7 +167,7 @@ CREATE TABLE PackageComments ( PRIMARY KEY (ID), INDEX (UsersID), INDEX (PackageID), - FOREIGN KEY (UsersID) REFERENCES Users(ID) ON SET NULL, + FOREIGN KEY (UsersID) REFERENCES Users(ID) ON DELETE SET NULL, FOREIGN KEY (DelUsersID) REFERENCES Users(ID) ON DELETE CASCADE, FOREIGN KEY (PackageID) REFERENCES Packages(ID) ON DELETE CASCADE ) ENGINE = InnoDB; -- 1.9.1

1 0

[aur-dev] Delete old fish shell packages
by Tyler Jameson Little 29 Mar '14

29 Mar '14

The following packages are not maintained, have been disowned and have no upvotes. They both have the same owner and were created within minutes of each other. The owner has expressed interest in the comments (first link) for them to be deleted. - https://aur.archlinux.org/packages/fishfish/ - https://aur.archlinux.org/packages/fishfish-git/ I'm not the owner, but it seems the owner has lost interest. Could a TU please delete these? Thanks!

3 2

[aur-dev] @archlinux.org email domain
by Acho Arnold 11 Mar '14

11 Mar '14

Please how can I get an email adress with the @archlinux.org domain? Acho Arnold Ewin <http://goo.gl/2hwP4m> Telephone: (+237) 77 84 51 63 Buea, Cameroon acho.arnold(a)live.com <mailto:acho.arnold@live.com>

3 2

[aur-dev] Feature Request
by John D Jones III 13 Feb '14

13 Feb '14

Not sure if this is the right way to do this, but, I guess I'll find out. I would like it if there was a way to display maintainer info in a search query. So, say I search vim and want to see all the maintainers who have a PKGBUILD in AUR with vim in it's name/description and perhaps, a list of all maintainers, their last submission date, number of packages, Number of Out of Date packages, IRC nick etc. I would imagine it'd be relatively simple, an SQL query and leverage the current search result page to display the fields. Thoughts? -- Thanks, John D Jones III UNIX Zealot; Perl Lover unixgeek1972(a)gmail.com jnbek1972(a)gmail.com http://zoelife4u.org/

1 0

[aur-dev] [PATCH] passreset.php: Make error messages translatable
by Lukas Fleischer 10 Feb '14

10 Feb '14

This fixes a regression introduced in commit 48b7407 (passreset.php: Refactor HTML, 2014-01-08). Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- web/html/passreset.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/html/passreset.php b/web/html/passreset.php index e926161..6fade6b 100644 --- a/web/html/passreset.php +++ b/web/html/passreset.php @@ -62,9 +62,9 @@ html_header(__("Password Reset")); <h2><?= __("Password Reset"); ?></h2> <?php if ($step == 'confirm'): ?> - <p>Check your e-mail for the confirmation link.</p> + <p><?= __('Check your e-mail for the confirmation link.') ?></p> <?php elseif ($step == 'complete'): ?> - <p>Your password has been reset successfully.</p> + <p><?= __('Your password has been reset successfully.') ?></p> <?php elseif (isset($_GET['resetkey'])): ?> <?php if ($error): ?> <ul class="errorlist"><li><?= $error ?></li></ul> -- 1.8.5.4

1 0

[aur-dev] [PATCH 1/3] Highlight the AUR link in the navigation bar
by Lukas Fleischer 10 Feb '14

10 Feb '14

Fixes FS#38498. Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- web/html/css/aur.css | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/web/html/css/aur.css b/web/html/css/aur.css index b78ce3e..bed39e8 100644 --- a/web/html/css/aur.css +++ b/web/html/css/aur.css @@ -1,4 +1,8 @@ /* AUR-specific customizations to "archweb.css". */ +#archnavbar.anb-aur ul li#anb-aur a { + color: white !important; +} + #lang_sub { float: right; } -- 1.8.5.4

1 2

[aur-dev] [PATCH 1/3] Remove LastVoted column
by Lukas Fleischer 09 Feb '14

09 Feb '14

This has been introduced by commit aae43d9 (started working on package comments, 2005-03-05) but it seems to be of no practical use. Remove the field to save some space. Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- schema/aur-schema.sql | 1 - web/lib/acctfuncs.inc.php | 3 --- web/lib/pkgfuncs.inc.php | 6 ------ web/template/account_details.php | 6 ------ web/template/account_search_results.php | 2 -- web/template/search_accounts_form.php | 1 - 6 files changed, 19 deletions(-) diff --git a/schema/aur-schema.sql b/schema/aur-schema.sql index c01701c..86f7563 100644 --- a/schema/aur-schema.sql +++ b/schema/aur-schema.sql @@ -32,7 +32,6 @@ CREATE TABLE Users ( LangPreference VARCHAR(5) NOT NULL DEFAULT 'en', IRCNick VARCHAR(32) NOT NULL DEFAULT '', PGPKey VARCHAR(40) NULL DEFAULT NULL, - LastVoted BIGINT UNSIGNED NOT NULL DEFAULT 0, LastLogin BIGINT UNSIGNED NOT NULL DEFAULT 0, LastLoginIPAddress INTEGER UNSIGNED NOT NULL DEFAULT 0, InactivityTS BIGINT UNSIGNED NOT NULL DEFAULT 0, diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php index f705574..0207bbd 100644 --- a/web/lib/acctfuncs.inc.php +++ b/web/lib/acctfuncs.inc.php @@ -373,9 +373,6 @@ function search_results_page($UTYPE,$O=0,$SB="",$U="",$T="", case 'i': $q.= "ORDER BY IRCNick, AccountTypeID "; break; - case 'v': - $q.= "ORDER BY LastVoted, Username "; - break; default: $q.= "ORDER BY Username, AccountTypeID "; break; diff --git a/web/lib/pkgfuncs.inc.php b/web/lib/pkgfuncs.inc.php index 59cc975..5800a26 100644 --- a/web/lib/pkgfuncs.inc.php +++ b/web/lib/pkgfuncs.inc.php @@ -1072,12 +1072,6 @@ function pkg_vote ($atype, $ids, $action=true) { $dbh->exec($q); if ($action) { - $q = "UPDATE Users SET LastVoted = UNIX_TIMESTAMP() "; - $q.= "WHERE ID = $uid"; - $dbh->exec($q); - } - - if ($action) { return array(true, __("Your votes have been cast for the selected packages.")); } else { return array(true, __("Your votes have been removed from the selected packages.")); diff --git a/web/template/account_details.php b/web/template/account_details.php index 680a52e..5ba01d9 100644 --- a/web/template/account_details.php +++ b/web/template/account_details.php @@ -44,12 +44,6 @@ </td> </tr> <tr> - <th><?= __("Last Voted") . ":" ?></th> - <td> - <?= $row["LastVoted"] ? date("Y-m-d", $row["LastVoted"]) : __("Never"); ?> - </td> - </tr> - <tr> <th>Links:</th> <td><ul> <li><a href="<?= get_uri('/packages/'); ?>?K=<?= $row['Username'] ?>&SeB=m"><?= __("View this user's packages") ?></a></li> diff --git a/web/template/account_search_results.php b/web/template/account_search_results.php index ae7c112..bd4ee29 100644 --- a/web/template/account_search_results.php +++ b/web/template/account_search_results.php @@ -13,7 +13,6 @@ else: <th><?= __("Real Name") ?></th> <th><?= __("IRC Nick") ?></th> <th><?= __("PGP Key Fingerprint") ?></th> - <th><?= __("Last Voted") ?></th> <th><?= __("Edit Account") ?></th> </tr> </thead> @@ -42,7 +41,6 @@ else: <td><?php $row["RealName"] ? print htmlspecialchars($row["RealName"],ENT_QUOTES) : print " " ?></td> <td><?php $row["IRCNick"] ? print htmlspecialchars($row["IRCNick"],ENT_QUOTES) : print " " ?></td> <td><?php $row["PGPKey"] ? print html_format_pgp_fingerprint($row["PGPKey"]) : print " " ?></td> - <td><?php $row["LastVoted"] ? print date("Y-m-d", $row["LastVoted"]) : print __("Never") ?></td> <td> <?php if ($UTYPE == "Trusted User" && $row["AccountType"] == "Developer"): diff --git a/web/template/search_accounts_form.php b/web/template/search_accounts_form.php index 202b1aa..d7f54be 100644 --- a/web/template/search_accounts_form.php +++ b/web/template/search_accounts_form.php @@ -57,7 +57,6 @@ <option value="t"><?= __("Account Type"); ?></option> <option value="r"><?= __("Real Name"); ?></option> <option value="i"><?= __("IRC Nick"); ?></option> - <option value="v"><?= __("Last vote"); ?></option> </select> </td> </tr> -- 1.8.5.4

1 2