- Aur-dev - lists.archlinux.org

[aur-dev] [PATCH 1/2] passreset.php: Refactor HTML
by Lukas Fleischer 08 Jan '14

08 Jan '14

* Use the "errorlist" class for errors. * Refactor some code. * Properly display error messages when requesting a key. Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- web/html/passreset.php | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/web/html/passreset.php b/web/html/passreset.php index 94a1ad9..59fd4bc 100644 --- a/web/html/passreset.php +++ b/web/html/passreset.php @@ -56,16 +56,14 @@ html_header(__("Password Reset")); <div class="box"> <h2><?= __("Password Reset"); ?></h2> + <?php if ($step == 'confirm'): ?> + <p>Check your e-mail for the confirmation link.</p> + <?php elseif ($step == 'complete'): ?> + <p>Your password has been reset successfully.</p> + <?php elseif (isset($_GET['resetkey'])): ?> <?php if ($error): ?> - <p><span class="error"><?= $error ?></span></p> - <?php endif;?> - <?php - if ($step == 'confirm') { - echo __('Check your e-mail for the confirmation link.'); - } elseif ($step == 'complete') { - echo __('Your password has been reset successfully.'); - } elseif (isset($_GET['resetkey'])) { - ?> + <ul class="errorlist"><li><?= $error ?></li></ul> + <?php endif; ?> <form action="" method="post"> <table> <tr> @@ -84,18 +82,19 @@ html_header(__("Password Reset")); <br /> <input type="submit" class="button" value="<?= __('Continue') ?>" /> </form> - <?php - } else { - ?> + <?php else: ?> <p><?= __('If you have forgotten the e-mail address you used to register, please send a message to the %saur-general%s mailing list.', '<a href="https://mailman.archlinux.org/mailman/listinfo/aur-general">', '</a>'); ?></p> + <?php if ($error): ?> + <ul class="errorlist"><li><?= $error ?></li></ul> + <?php endif; ?> <form action="" method="post"> <p><?= __("Enter your e-mail address:"); ?> <input type="text" name="email" size="30" maxlength="64" /></p> <input type="submit" class="button" value="<?= __('Continue') ?>" /> </form> - <?php } ?> + <?php endif; ?> </div> <?php -- 1.8.5.2

1 1

[aur-dev] AUR generation next?
by Karol Blazewicz 07 Jan '14

07 Jan '14

Some people think that AUR in the current state is an unmaintainable mess, with many outdated packages, PKGBUILDs that haven't been updated in a looong while https://bbs.archlinux.org/viewtopic.php?id=175171 Some users suggest transforming AUR into a wiki, some would like to use git for pull requests etc., others support an annual wipe i.e. AUR is moved into a read-only state (and moved to aur-old address) and maintainers are asked to resubmit PKGBUILDs - this would keep old comments and votes and over time only the PKGBUILDs that actually are maintained would be kept in the AUR. What are the thoughts of the AUR overlords about all this? If you give such grassroots effort a NACK, there's no point in the discussion, until further notice.

3 2

[aur-dev] Remove package search auto-complete
by Callan 06 Jan '14

06 Jan '14

Hi, Before I start off on my rant I just want to say I am not trying to attack whoever committed this feature originally. Please don't take it personally. Can you please please please apply this patch to remove the auto-complete popup on the front page quick search. This is such an obnoxious use of javascript and I honestly see no point in it. I understand the intention fine but, in practice, I find myself having to hit enter 3 times just to do a search. Every. Single. Time. I've wasted more time pressing enter now than I ever did using my eyes to manually filter the result list on the next page. What's worse is as far as I can tell this is literally the only time javascript is used in the AUR and we are pulling in two entire libraries for it. What's the deal?? This cuts even deeper for me because I spent months trying to convince people in the past that, shock and horror, the web uses javascript these days and we can take advantage of it. Now it's allowed in and it's not even being used properly. If anyone disagrees with me, please say why, because I'd love to have a debate on the merits of this feature. Otherwise, can we get this applied as soon as possible. Thanks -- Callan

5 7

Re: [aur-dev] [PATCH] Go to package when selecting a typeahead suggestion
by Connor Behan 03 Jan '14

03 Jan '14

On 01/01/14 03:52 PM, Lukas Fleisher wrote: > Directly jump to the package details when selecting an entry from the > drop-down list. > > Implements FS#34471. > > Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> > --- > web/html/home.php | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/web/html/home.php b/web/html/home.php > index ddbb0fd..e80efaa 100644 > --- a/web/html/home.php > +++ b/web/html/home.php > @@ -118,7 +118,11 @@ $(document).ready(function() { > matcher: function(item) { return true; }, > sorter: function(items) { return items; }, > menu: '<ul class="pkgsearch-typeahead"></ul>', > - items: 20 > + items: 20, > + updater: function(item) { > + document.location = '/packages/' + item; > + return item; > + } > }).attr('autocomplete', 'off'); > }); > </script> > -- 1.8.5.2 Would this apply to the package search on archlinux.org as well as aur.archlinux.org? The main argument for disabling suggestions altogether is that a native text entry (from an HTML input tag) spawns a non-native suggestion widget. I know this cannot be helped until search suggestions become a web standard, but people still might think it looks tacky.

1 0

Re: [aur-dev] Remove package search auto-complete
by Connor Behan 31 Dec '13

31 Dec '13

On 30/12/13 12:09 AM, callan(a)zoocar.org wrote: > Hi, > > Before I start off on my rant I just want to say I am not trying to attack whoever committed this feature originally. Please don't take it personally. > > Can you please please please apply this patch to remove the auto-complete popup on the front page quick search. This is such an obnoxious use of javascript and I honestly see no point in it. I understand the intention fine but, in practice, I find myself having to hit enter 3 times just to do a search. Every. Single. Time. I've wasted more time pressing enter now than I ever did using my eyes to manually filter the result list on the next page. > > What's worse is as far as I can tell this is literally the only time javascript is used in the AUR and we are pulling in two entire libraries for it. What's the deal?? This cuts even deeper for me because I spent months trying to convince people in the past that, shock and horror, the web uses javascript these days and we can take advantage of it. Now it's allowed in and it's not even being used properly. > > If anyone disagrees with me, please say why, because I'd love to have a debate on the merits of this feature. Otherwise, can we get this applied as soon as possible. > > Thanks I laughed when I saw this because I am in the middle of the same argument with Wikipedia: https://bugzilla.wikimedia.org/show_bug.cgi?id=52812 Even though the search suggestions on the AUR are not the most annoying ones I've seen, the feature is inherently hackish and I support the patch to remove them. The Archweb suggestions for the official repos should be treated symmetrically.

1 0

Re: [aur-dev] Add a VCS field in the package details page
by Yardena Cohen 30 Nov '13

30 Nov '13

01walid <01walid at gmail.com> wrote: >> Just an *optional* field to be added when submitting the package, where -if >> available- the package submitter can add the PKGBUILD repo link (on Github, >> bitbucket ..etc) Dustin Falgout <dustin at falgout.us> wrote: > I'm not sure that github is the right solution > as we would be relying on an outside service that could possibly change > or disappear at any time in the future. Perhaps something similar to > how wikis allow revisions to be made and viewed by anyone but don't > replace the original content until approved? > > I don't see a way to do anything about this issue that wouldn't be > considered a new feature to the AUR I think this proposal is something simpler, almost akin to url= in a PKGBUILD. I too keep my PKGBUILDs in a git repo, and sometimes I've even put the github link as the upstream URL. It would be nice if there was a more correct place for that. Maintainers can use their own host, doesn't have to be github. Obviously we're responsible for avoiding dead links, just as in url= and source= etc.

2 1

[aur-dev] Add a VCS field in the package details page
by 01walid 28 Nov '13

28 Nov '13

Greetings, I'm new to this mailing list. and first of all, sorry if the idea I'm about to introduce is repeated or annoying (discussed before), I just want to suggest it. *What I noticed:* - Many AUR package maintainers/submitter are developers, or at least have a VCS knowledge (and a Github, Bitbucket ..etc account) - Almost all AUR comments are just PKGBUILDs adjustments, suggestions, enhancement, fixes, new links/md5's or bug reports, written in the comment itself. - Many updated PKGBUILDs do just what suggested in comments (not so DRY), just a copy and a past (the community is helping). - Many outdated PKGBUILDs are just outdated because the package owner is too busy to update it. *What I suggest:* Just an *optional* field to be added when submitting the package, where -if available- the package submitter can add the PKGBUILD repo link (on Github, bitbucket ..etc), the link is visible in the package details page. so when the PKGBUILD is outdated or has a problem, the community can suggest pull requests directly to the repo, and make the life easier for the package maintainer. If you want to go further (and I don't know how's that technically feasible right now), you can make something that automatically pull the PKGBUILD directly from the repo link (or the PKGBUILD file direct link from that repo) That's it, correct me if I'm just talking nonsense. Thanks.

3 2

[aur-dev] [PATCH] don't treat colon as part of package dependency name
by Daniel Albers 26 Nov '13

26 Nov '13

Dependencies can have a description appended, separated by a colon. Don't treat this colon as part of the dependency name. Signed-off-by: Daniel Albers <daniel(a)lbe.rs> --- web/html/pkgsubmit.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php index d2fe512..305acc7 100644 --- a/web/html/pkgsubmit.php +++ b/web/html/pkgsubmit.php @@ -421,7 +421,7 @@ if ($uid): } if (!empty($depends)) { foreach ($depends as $dep) { - $deppkgname = preg_replace("/(<|<=|=|>=|>).*/", "", $dep); + $deppkgname = preg_replace("/(<|<=|=|>=|>|:).*/", "", $dep); $depcondition = str_replace($deppkgname, "", $dep); if ($deppkgname == "") { -- 1.8.4.2

3 3

[aur-dev] URL redirect should be set to the merged package
by 郑文辉(Techlive Zheng) 27 Oct '13

27 Oct '13

Currently, if a package gets merged into another package, the URL link to the merged package will say 404, this should not happen, instead, a redirection should be made to the package that was merged into. If a new package with the same name as the merged package is uploaded again, then, the redirection will be removed. Which means, there should be a record of the merging activities. When a package is being queried, if the package exists then just return it, if not, check the merging records for the latest merging record, and redirect the page to the new package.

2 1

[aur-dev] [PATCH] Convert adopt/disown package action link to form
by canyonknight 08 Sep '13

08 Sep '13

* Changes adopting/disowning packages to use GET instead of POST * Uses CSS to make form submit button look like a link * Complements commit 3bc951e3d87eaf692a7e47cf16a28d838c7cb2bd Signed-off-by: canyonknight <canyonknight(a)gmail.com> --- web/html/index.php | 6 ++++++ web/template/pkg_details.php | 34 +++++++++++++++++----------------- 2 files changed, 23 insertions(+), 17 deletions(-) diff --git a/web/html/index.php b/web/html/index.php index be6c98d..ccc94d2 100644 --- a/web/html/index.php +++ b/web/html/index.php @@ -25,6 +25,12 @@ if (!empty($tokens[1]) && '/' . $tokens[1] == get_pkg_route()) { /* TODO: Remove support for legacy URIs and move these * actions to separate modules. */ switch ($tokens[3]) { + case "adopt": + $_POST['do_Adopt'] = __('Adopt'); + break; + case "disown": + $_POST['do_Disown'] = __('Disown'); + break; case "vote": $_POST['do_Vote'] = __('Vote'); break; diff --git a/web/template/pkg_details.php b/web/template/pkg_details.php index 0484924..bc20a22 100644 --- a/web/template/pkg_details.php +++ b/web/template/pkg_details.php @@ -89,24 +89,24 @@ $sources = package_sources($row["ID"]); <li><a href="<?= get_pkg_uri($row['Name']) . 'merge/'; ?>"><?= __('Merge Package'); ?></a></li> <?php endif; ?> <?php endif; ?> + + <?php if ($uid && $row["MaintainerUID"] === NULL): ?> + <li> + <form action="<?= get_pkg_uri($row['Name']) . 'adopt/'; ?>" method="post"> + <input type="hidden" name="token" value="<?= htmlspecialchars($_COOKIE['AURSID']) ?>" /> + <input type="submit" class="button text-button" name="do_Adopt" value="<?= __('Adopt Package') ?>" /> + </form> + </li> + <?php elseif ($uid && $uid == $row["MaintainerUID"] || + $atype == "Trusted User" || $atype == "Developer"): ?> + <li> + <form action="<?= get_pkg_uri($row['Name']) . 'disown/'; ?>" method="post"> + <input type="hidden" name="token" value="<?= htmlspecialchars($_COOKIE['AURSID']) ?>" /> + <input type="submit" class="button text-button" name="do_Disown" value="<?= __('Disown Package') ?>" /> + </form> + </li> + <?php endif; ?> </ul> - <?php if ($uid): ?> - <form action="<?= htmlspecialchars(get_pkg_uri($row['Name']), ENT_QUOTES); ?>" method="post"> - <div> - <input type="hidden" name="IDs[<?= $row['ID'] ?>]" value="1" /> - <input type="hidden" name="ID" value="<?= $row['ID'] ?>" /> - <input type="hidden" name="token" value="<?= htmlspecialchars($_COOKIE['AURSID']) ?>" /> - </div> - <p> - <?php if ($row["MaintainerUID"] === NULL): ?> - <input type="submit" class="button" name="do_Adopt" value="<?= __("Adopt Package") ?>" /> - <?php elseif ($uid == $row["MaintainerUID"] || - $atype == "Trusted User" || $atype == "Developer"): ?> - <input type="submit" class="button" name="do_Disown" value="<?= __("Disown Package") ?>" /> - <?php endif; ?> - </p> - </form> - <?php endif; ?> </div> </div> -- 1.8.4

2 1