- Aur-dev - lists.archlinux.org

[aur-dev] AUR 2.2.1 released
by Lukas Fleischer 17 Aug '13

17 Aug '13

Important changes: * Retrieve package details after package actions are processed. * Update aurblup for pacman 4.1 API changes. * Fix PHP 5.5 compatibility. Check the Git log [1] for a complete list. [1] http://projects.archlinux.org/aur.git/log/?id=v2.2.1

1 0

[aur-dev] [acpi_call-git] makepkg fails when applying x86_64 patch
by Vadim Kochan 17 Aug '13

17 Aug '13

Hi AUR devs, I just tried to makepkg for acpi_call-git package and it fails because of rejected acpi_call-x86_64.patch. I compared the patch and original file and they are with the same changes. As a local fix I used: --- PKGBUILD 2013-08-17 03:36:47.690127666 +0300 +++ PKGBUILD 2013-08-17 03:37:31.380127165 +0300 @@ -46,12 +46,6 @@ sed -i 's|/lib/modules/|/usr/lib/modules/|g' ./Makefile || return 1 fi - ## x86_64 Patch - if [ "$CARCH" = "x86_64" ]; then - msg "Patching for x86_64 systems" - patch -p1 -i ${srcdir}/acpi_call-x86_64.patch - fi - ## Build make } I think that patch should be removed too. Thanks, Vadim

3 2

[aur-dev] [PATCH 0/7] Display vote results on the Proposal Details page
by Lukas Fleischer 08 Aug '13

08 Aug '13

This is a resubmission of the two patch series I submitted yesterday with Florian's suggestions incorporated. Further comments welcome. Lukas Fleischer (7): Allow for setting an account's inactivity status Store the number of active TUs when starting a vote Show participation in vote details Add a quorum column to TU_VoteInfo Add a vote type to the TU proposal form tu_details.php: Avoid inline computations tu_details.php: Display vote result UPGRADING | 18 +++++++++++++++ support/schema/aur-schema.sql | 3 +++ web/html/account.php | 5 +++-- web/html/addvote.php | 46 ++++++++++++++++++++++++++++---------- web/lib/acctfuncs.inc.php | 42 ++++++++++++++++++++++++++-------- web/template/account_details.php | 6 +++++ web/template/account_edit_form.php | 5 +++++ web/template/tu_details.php | 43 +++++++++++++++++++++++++++++++---- 8 files changed, 141 insertions(+), 27 deletions(-) -- 1.8.4.rc1.383.g13e9f3f

3 11

[aur-dev] [PATCH 1/2] Store active TUs for each vote
by Lukas Fleischer 06 Aug '13

06 Aug '13

This allows for easily keeping track of TUs that become active during a voting period later. Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- UPGRADING | 18 +++++++++++++----- support/schema/aur-schema.sql | 10 +++++++++- web/lib/acctfuncs.inc.php | 23 ++++++++++++++--------- 3 files changed, 36 insertions(+), 15 deletions(-) diff --git a/UPGRADING b/UPGRADING index a300a91..740078c 100644 --- a/UPGRADING +++ b/UPGRADING @@ -10,13 +10,21 @@ From 2.2.0 to 2.3.0 ALTER TABLE Users ADD COLUMN InactivityTS BIGINT NOT NULL DEFAULT 0; ---- -2. Add fields to store the number of active TUs and the quorum to the - "TU_VoteInfo" table: +2. Add a field to store the quorum to the "TU_VoteInfo" table: ---- -ALTER TABLE TU_VoteInfo - ADD COLUMN ActiveTUs tinyint(3) unsigned NOT NULL default '0', - ADD COLUMN Quorum decimal(2, 2) unsigned NOT NULL; +ALTER TABLE TU_VoteInfo ADD COLUMN Quorum decimal(2, 2) unsigned NOT NULL; +---- + +3. Create the "TU_VoteActive" table: + +---- +CREATE TABLE IF NOT EXISTS TU_VoteActive ( + VoteID int(10) unsigned NOT NULL, + UserID int(10) unsigned NOT NULL, + FOREIGN KEY (VoteID) REFERENCES TU_VoteInfo(ID) ON DELETE CASCADE, + FOREIGN KEY (UserID) REFERENCES Users(ID) ON DELETE CASCADE +) ENGINE = InnoDB; ---- From 2.1.0 to 2.2.0 diff --git a/support/schema/aur-schema.sql b/support/schema/aur-schema.sql index 59da3aa..6efe91c 100644 --- a/support/schema/aur-schema.sql +++ b/support/schema/aur-schema.sql @@ -203,11 +203,19 @@ CREATE TABLE IF NOT EXISTS TU_VoteInfo ( Yes tinyint(3) unsigned NOT NULL default '0', No tinyint(3) unsigned NOT NULL default '0', Abstain tinyint(3) unsigned NOT NULL default '0', - ActiveTUs tinyint(3) unsigned NOT NULL default '0', PRIMARY KEY (ID), FOREIGN KEY (SubmitterID) REFERENCES Users(ID) ON DELETE CASCADE ) ENGINE = InnoDB; +-- TUs being active during a specific voting period +-- +CREATE TABLE IF NOT EXISTS TU_VoteActive ( + VoteID int(10) unsigned NOT NULL, + UserID int(10) unsigned NOT NULL, + FOREIGN KEY (VoteID) REFERENCES TU_VoteInfo(ID) ON DELETE CASCADE, + FOREIGN KEY (UserID) REFERENCES Users(ID) ON DELETE CASCADE +) ENGINE = InnoDB; + -- Individual vote records -- CREATE TABLE IF NOT EXISTS TU_Votes ( diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php index 9df1856..3f7b595 100644 --- a/web/lib/acctfuncs.inc.php +++ b/web/lib/acctfuncs.inc.php @@ -618,19 +618,18 @@ function open_user_proposals($user) { function add_tu_proposal($agenda, $user, $votelength, $quorum, $submitteruid) { $dbh = DB::connect(); - $q = "SELECT COUNT(*) FROM Users WHERE AccountTypeID = 2 AND "; - $q.= "InactivityTS = 0"; - $result = $dbh->query($q); - $row = $result->fetch(PDO::FETCH_NUM); - $active_tus = $row[0]; - $q = "INSERT INTO TU_VoteInfo (Agenda, User, Submitted, End, Quorum, "; - $q.= "SubmitterID, ActiveTUs) VALUES "; + $q.= "SubmitterID) VALUES "; $q.= "(" . $dbh->quote($agenda) . ", " . $dbh->quote($user) . ", "; $q.= "UNIX_TIMESTAMP(), UNIX_TIMESTAMP() + " . $dbh->quote($votelength); - $q.= ", " . $dbh->quote($quorum) . ", " . $submitteruid . ", "; - $q.= $active_tus . ")"; + $q.= ", " . $dbh->quote($quorum) . ", " . $submitteruid . ")"; $result = $dbh->exec($q); + $vote_id = last_insert_id(); + + $q = "INSERT INTO TU_VoteActive (VoteID, UserID) SELECT "; + $q.= $vote_id . " AS VoteID, ID AS UserID FROM Users WHERE "; + $q.= "AccountTypeID = 2 AND InactivityTS = 0"; + $dbh->exec($q); } /** @@ -1026,6 +1025,12 @@ function vote_details($voteid) { $result = $dbh->query($q); $row = $result->fetch(PDO::FETCH_ASSOC); + $q = "SELECT COUNT(*) FROM TU_VoteActive WHERE VoteID = "; + $q.= intval($voteid); + $result = $dbh->query($q); + $row_ = $result->fetch(PDO::FETCH_NUM); + $row['ActiveTUs'] = $row_[0]; + return $row; } -- 1.8.4.rc1.383.g13e9f3f

2 3

[aur-dev] [PATCH 1/3] Add a quorum column to TU_VoteInfo
by Lukas Fleischer 04 Aug '13

04 Aug '13

This allows for specifying a quorum per vote and sets a basis for implementing automated acceptance/rejection of TU votes later. Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- UPGRADING | 6 ++++-- support/schema/aur-schema.sql | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/UPGRADING b/UPGRADING index 307ed8d..a300a91 100644 --- a/UPGRADING +++ b/UPGRADING @@ -10,11 +10,13 @@ From 2.2.0 to 2.3.0 ALTER TABLE Users ADD COLUMN InactivityTS BIGINT NOT NULL DEFAULT 0; ---- -2. Add a field to store the number of active TUs to the "TU_VoteInfo" table: +2. Add fields to store the number of active TUs and the quorum to the + "TU_VoteInfo" table: ---- ALTER TABLE TU_VoteInfo - ADD COLUMN ActiveTUs tinyint(3) unsigned NOT NULL default '0'; + ADD COLUMN ActiveTUs tinyint(3) unsigned NOT NULL default '0', + ADD COLUMN Quorum decimal(2, 2) unsigned NOT NULL; ---- From 2.1.0 to 2.2.0 diff --git a/support/schema/aur-schema.sql b/support/schema/aur-schema.sql index 51f9601..59da3aa 100644 --- a/support/schema/aur-schema.sql +++ b/support/schema/aur-schema.sql @@ -198,6 +198,7 @@ CREATE TABLE IF NOT EXISTS TU_VoteInfo ( User VARCHAR(32) NOT NULL, Submitted bigint(20) unsigned NOT NULL, End bigint(20) unsigned NOT NULL, + Quorum decimal(2, 2) unsigned NOT NULL, SubmitterID int(10) unsigned NOT NULL, Yes tinyint(3) unsigned NOT NULL default '0', No tinyint(3) unsigned NOT NULL default '0', -- 1.8.4.rc1.383.g13e9f3f

2 6

[aur-dev] [PATCH 0/3] Automated TU vote participation calculation
by Lukas Fleischer 04 Aug '13

04 Aug '13

The first idea is to allow for setting one's inactivity status using the AUR instead of having to consult several different sources (mailing lists, the Wiki, archweb, ...) This allows for doing an automated calculation of vote participation. Note that this currently doesn't really match the TU bylaws since the bylaws define active TUs as the number of active TUs at the *end* of the vote, whereas this patch counts TUs when the vote is started. We should come up with a proper solution before this is merged (some additional patches; amend the bylaws?) Comments welcome. Lukas Fleischer (3): Allow for setting an account's inactivity status Store the number of active TUs when starting a vote Show participation in vote details UPGRADING | 16 ++++++++++++++++ support/schema/aur-schema.sql | 2 ++ web/html/account.php | 5 +++-- web/lib/acctfuncs.inc.php | 39 ++++++++++++++++++++++++++++++-------- web/template/account_details.php | 6 ++++++ web/template/account_edit_form.php | 9 +++++++++ web/template/tu_details.php | 6 ++++++ 7 files changed, 73 insertions(+), 10 deletions(-) -- 1.8.4.rc1.383.g13e9f3f

2 4

[aur-dev] AUR 2.1.0 released
by Lukas Fleischer 10 Jul '13

10 Jul '13

Changes since 2.0.1: * Typeahead suggest for packages. * Fix account editing and hijacking vulnerability. * Fix account privilege escalation vulnerability. * Clear a user's active sessions following account suspension. * Several translation fixes/updates. * pkgsubmit.php: Parse .AURINFO metadata. .AURINFO files can now be included in source packages to overwrite specific PKGBUILD fields. .AURINFO files are parsed line by line. The syntax for each line is "key = value", where key is any of the following field names: * pkgname * pkgver * pkgdesc * url * license * depend Multiple "depend" lines can be specified to add multiple dependencies. You can check the Git log [1] for a complete list of commits. The official Arch Linux AUR setup [2] has already been upgraded! [1] https://projects.archlinux.org/aur.git/log/?id=v2.1.0 [2] https://aur.archlinux.org/

7 11

[aur-dev] Spam comments
by Florian Dejonckheere 02 Jun '13

02 Jun '13

I stumbled upon a few spam comments, from an account that's already suspended according to the mailing list archives. The spammer's account is JOYOAUTO. A quick search through Google turns up the following package comments are polluted: o catalyst-hook (https://aur.archlinux.org/packages/catalyst-hook) o catalyst-daemon (https://aur.archlinux.org/packages/catalyst-daemon) o clamtk (https://aur.archlinux.org/packages/clamtk) o apc (https://aur.archlinux.org/packages/apc) o arbtt (https://aur.archlinux.org/packages/arbtt) o btscanner (https://aur.archlinux.org/packages/btscanner)<https://aur.archlinux.org/packages/bt-scanner> o alt-ergo (https://aur.archlinux.org/packages/alt-ergo) o albumart (https://aur.archlinux.org/packages/albumart) o autoaur (https://aur.archlinux.org/packages/autoaur) o atier (https://aur.archlinux.org/packages/catalyst-hook) o api-sanity-checker (https://aur.archlinux.org/packages/api-sanity-checker) o boost-build-config (https://aur.archlinux.org/packages/boost-build-config) o audiveris-beta (https://aur.archlinux.org/packages/audiveris-beta) The archives and Google also indicate spam comments on some of the packages were already removed. Isn't there a way to delete all of a given user's comments? Thanks *Florian Dejonckheere* florian(a)floriandejonckheere.be http://www.floriandejonckheere.be floriandejonckheere sip:florian@floriandejonckheere.be

2 1

[aur-dev] Notification System Overhaul
by canyonknight 08 May '13

08 May '13

Hello all, The current notification system for the AUR is lacking in features and isn't too pretty on the code side of things. Before I try and finalize the code I have, I wanted to lay out what I was planning for some feedback. Right now the AUR only allows for notifications when a user adds a comment. I would like users to have access to notifications for the following package actions: - New comments on packages - Package updates - Package adoption/orphaning - Package deletion/merging I think having the ability to select those 4 types of notifications brings a lot more flexibility while not being overly complicated. As for the AUR web interface changes, the package details page would feature a link to modify that specific package's notifications. The page would feature a list of all potential types of notifications the user can subscribe to with a check box next to each option. The user can then select all/some/none of the notifications for that specific package. On the backend side of things, swiftmailer seems to be a decent choice for sending the notifications. It is actively developed, has all the features the AUR would really need, and has a nice interface on the programming side of things. All the notification code mixed in with package functions and the like could be ripped out allowing for easier modification down the road. Ideally the following bugs should be closed after everything is implemented: FS#15412 - Send a notification when a package is orphaned or adopted FS#19948 - Add whether or not I'm the maintainer to the aur-notify email su FS#27687 - Merging packages does not transfer the notify list. FS#30109 - email notification upon package update FS#31850 - Send notification e-mails in preferred user language FS#31851 - Overhaul e-mail notification system FS#34843 - Make bugs/AUR messages more visible Does anyone have anything major they would like to see out of the notification system? Is there anything anyone disagrees with? Regards, Jason

3 4

[aur-dev] Adopted sakura-bzr package
by Evan Pitstick 07 May '13

07 May '13

I just adopted the sakura-bzr package and as it's my first aur submission I thought I'd request some comments. You can find the files here: https://github.com/xaocon/sakura-bzr/blob/master/PKGBUILD https://github.com/xaocon/sakura-bzr/blob/master/sakura-bzr.install One question I had in particular was about adding a variable. This is clearly discouraged in the documentation. I used ${pkgname%-bzr} in the source URL (as well as in several other places in the PKGBUILD). The website doesn't seem to parse the source line as I expected. I curious if it makes more sense to also create a _pkgname var and use it instead. All comments/suggestions welcome. Thanks, -Evan

3 3